Skip to content

nextchanges: Automatically add the PR link to a newly added nextchanges fragments - #6177

Open
janniklasrose wants to merge 7 commits into
mainfrom
janniklasrose/nextchanges-auto-add-pr-number
Open

nextchanges: Automatically add the PR link to a newly added nextchanges fragments#6177
janniklasrose wants to merge 7 commits into
mainfrom
janniklasrose/nextchanges-auto-add-pr-number

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Changes

Run a workflow to automatically add the PR number to a nextchanges fragment if that PR adds that file

Why

Often forgotten and annoying to do by hand

Tests

6db9a9f on this PR got pushed by the bot (run)

janniklasrose and others added 4 commits August 5, 2026 15:52
The databricks org has an IP allow list that GitHub-hosted runners are not
on, so `gh api` from ubuntu-latest failed with HTTP 403. Every other
workflow in this repo that calls the API already runs on this group.

Co-authored-by: Isaac
@janniklasrose
janniklasrose requested a review from denik August 5, 2026 15:08
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: fa674e2

Run: 31375960313

Env 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 4 4 291 1116 4:39
💚​ aws windows 4 4 293 1114 4:42
💚​ azure linux 4 4 290 1116 4:52
💚​ azure windows 4 4 292 1114 5:31
💚​ gcp linux 1 5 291 1116 5:43
💚​ gcp windows 1 5 293 1114 4:36
8 interesting tests: 4 RECOVERED, 4 SKIP
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo 💚​R 💚​R 💚​R 💚​R 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo/root 💚​R 💚​R 💚​R 💚​R
💚​ TestFetchRepositoryInfoAPI_FromRepo/subdir 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
5:11 azure windows TestAccept
4:14 gcp windows TestAccept
4:02 aws windows TestAccept

yolocs pushed a commit to yolocs/dbcli that referenced this pull request Aug 6, 2026
@janniklasrose janniklasrose changed the title Automatically add PR link to nextchanges fragments during the PR that adds them nextchanges: Automatically add the PR link to a newly added nextchanges fragments Aug 10, 2026
Gate the job on !draft (mirroring maintainer-approval.yml) and add the
ready_for_review trigger so a fragment added while the PR was a draft gets
linked as soon as it's marked ready.

Co-authored-by: Isaac
Move the appended reference to the very end of an entry (after any trailing
period) instead of before the period, and only skip an entry that already
*ends* with a PR reference. A prior PR or issue cited in the body (e.g.
"Fixes #6030: …") no longer blocks appending the PR link at the end.

Co-authored-by: Isaac
@janniklasrose
janniklasrose marked this pull request as ready for review August 10, 2026 09:55
@janniklasrose
janniklasrose requested a review from pietern August 10, 2026 09:55
@github-actions

Copy link
Copy Markdown
Contributor

Waiting for approval

Based on git history, these people are best suited to review:

  • @pietern -- recent work in .github/workflows/, tools/, .agent/skills/pr-checklist/

Eligible reviewers: @andrewnester, @anton-107, @denik, @lennartkats-db, @renaudhartert-db, @shreyas-goenka, @simonfaltum

Suggestions based on git history. See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants